Fix non-thread safe crash in Paratext Settings when viewing history

[pmachapman]

This PR fixes a System.InvalidOperationException that occurs because the ScrText Setting's internal dictionary to map filenames to book numbers to is being populated while it is being read. See the Paratext source code for ProjectSettings.GetBookNumberFromFilename() for details of the cache implementation.

It is very difficult to recreate this crash locally (I have had it once or twice over the last year), but this bug occurs occasionally on live with a stack trace as follows:

System.InvalidOperationException Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct. 
    unknown System.ThrowHelper.ThrowInvalidOperationException_ConcurrentOperationsNotSupported()
    unknown System.Collections.Generic.Dictionary<TKey, TValue>.FindValue(TKey key)
    unknown Paratext.Data.ProjectSettingsAccess.ProjectSettings.GetBookNumberFromFilename(string bookFileName)
    unknown Paratext.Data.Repository.RevisionChangeInfo..ctor(VersionedText versionedText, HgRevision revision, List<T> revertedFiles)
    /home/runner/work/web-xforge/web-xforge/src/SIL.XForge.Scripture/Services/ParatextService.cs:2277 SIL.XForge.Scripture.Services.ParatextService+<GetRevisionHistoryAsync>d__81.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    /home/runner/work/web-xforge/web-xforge/src/SIL.XForge.Scripture/Services/ParatextService.cs:2307 SIL.XForge.Scripture.Services.ParatextService+<GetRevisionHistoryAsync>d__81.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Threading.Tasks.Sources.ManualResetValueTaskSourceCore<TResult>.ThrowForFailedGetResult()
    unknown SIL.XForge.Scripture.Services.ParatextService+<GetRevisionHistoryAsync>d__81.System.Threading.Tasks.Sources.IValueTaskSource<System.Boolean>.GetResult(short token)
    unknown Microsoft.AspNetCore.Mvc.NewtonsoftJson.AsyncEnumerableReader+<ReadInternal>d__5<T>.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown Microsoft.AspNetCore.Mvc.NewtonsoftJson.AsyncEnumerableReader+<ReadInternal>d__5<T>.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown System.Runtime.CompilerServices.TaskAwaiter<TResult>.GetResult()
    unknown Microsoft.AspNetCore.Mvc.Formatters.NewtonsoftJsonOutputFormatter+<WriteResponseBodyAsync>d__13.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<<InvokeResultAsync>g__Logged|22_0>d.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<<InvokeNextResultFilterAsync>g__Awaited|30_0>d<TFilter, TFilterAsync>.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResultExecutedContextSealed context)
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.ResultNext<TFilter, TFilterAsync>(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<<InvokeResultFilters>g__Awaited|28_0>d.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<<InvokeNextResourceFilter>g__Awaited|25_0>d.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<<InvokeFilterPipelineAsync>g__Awaited|20_0>d.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<<InvokeAsync>g__Logged|17_1>d.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<<InvokeAsync>g__Logged|17_1>d.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Authorization.AuthorizationMiddleware+<Invoke>d__11.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Authentication.AuthenticationMiddleware+<Invoke>d__6.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware+<Invoke>d__5.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware+<Invoke>d__3.MoveNext()
    unknown System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    unknown System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
    unknown Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl+<<Invoke>g__Awaited|10_0>d.MoveNext()

See:

• https://app.bugsnag.com/sil-international/scripture-forge-v2-plus/errors/693691dc1b029fa605183edf
• https://app.bugsnag.com/sil-international/scripture-forge-v2-plus/errors/6916555e657a87d3dab68f25

---

This change is 

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.77%. Comparing base (16b33f4) to head (0283a46).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3605   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files         610      610           
  Lines       37234    37235    +1     
  Branches     6080     6104   +24     
=======================================
+ Hits        30819    30820    +1     
  Misses       5498     5498           
  Partials      917      917           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RaymondLuong3]

@RaymondLuong3 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)

---

src/SIL.XForge.Scripture/Services/ParatextService.cs line 2260 at r1 (raw file):

            // The ScrText Settings maintains a non-thread safe dictionary cache of book filenames to book numbers.
            // We initialize it here to prevent issues when iterating over revisions below.
            _ = scrText.Settings.GetBookNumberFromFilename(string.Empty);

Looking at the paratext code, it looks like using the empty string should be fine and it will initiate the caching of the book and filenames.

Code quote:

            _ = scrText.Settings.GetBookNumberFromFilename(string.Empty);