-
-
Notifications
You must be signed in to change notification settings - Fork 5
Serval Admin: Detect faulted job, add draft-jobs.component tests #3546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3546 +/- ##
==========================================
+ Coverage 82.47% 82.91% +0.43%
==========================================
Files 605 605
Lines 36873 36876 +3
Branches 6044 6021 -23
==========================================
+ Hits 30412 30574 +162
+ Misses 5555 5389 -166
- Partials 906 913 +7 ☔ View full report in Codecov by Sentry. |
a09c57e to
e06ca0a
Compare
|
I'm not inclined to think this needs to go thru testing. |
79d1286 to
39d0ec8
Compare
39d0ec8 to
36fc490
Compare
|
I am still in progress getting the tests to work after rebasing. |
36fc490 to
33052a9
Compare
33052a9 to
9abbbbf
Compare
9abbbbf to
b16996e
Compare
b16996e to
85e5e48
Compare
|
I think the event logger may be mistakenly mixing up SF project ids and SF user ids sometimes. |
`BuildCompletedAsync` occurs and can alert about a Faulted job. Its sf project id is in payload.
85e5e48 to
72e2b2d
Compare
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmachapman reviewed 4 of 4 files at r1, 3 of 3 files at r3, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @marksvc)
BuildCompletedAsyncoccurs and can alert about a Faulted job. Its sf project id is in payload.This change is