Skip to content

Conversation

@marksvc
Copy link
Collaborator

@marksvc marksvc commented Oct 28, 2025

BuildCompletedAsync occurs and can alert about a Faulted job. Its sf project id is in payload.

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.91%. Comparing base (e625975) to head (72e2b2d).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3546      +/-   ##
==========================================
+ Coverage   82.47%   82.91%   +0.43%     
==========================================
  Files         605      605              
  Lines       36873    36876       +3     
  Branches     6044     6021      -23     
==========================================
+ Hits        30412    30574     +162     
+ Misses       5555     5389     -166     
- Partials      906      913       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksvc marksvc force-pushed the task/draft-jobs-tests branch from a09c57e to e06ca0a Compare October 28, 2025 22:00
@marksvc marksvc changed the title sa: add draft-jobs.component tests sa: detect faulted job, add draft-jobs.component tests Oct 28, 2025
@marksvc
Copy link
Collaborator Author

marksvc commented Oct 28, 2025

I'm not inclined to think this needs to go thru testing.

@marksvc marksvc force-pushed the task/draft-jobs-tests branch 2 times, most recently from 79d1286 to 39d0ec8 Compare October 28, 2025 22:21
@marksvc marksvc marked this pull request as ready for review October 28, 2025 22:50
@pmachapman pmachapman self-requested a review October 29, 2025 02:00
@pmachapman pmachapman self-assigned this Oct 29, 2025
@marksvc marksvc marked this pull request as draft October 29, 2025 17:18
@marksvc marksvc closed this Oct 29, 2025
@marksvc marksvc deleted the task/draft-jobs-tests branch October 29, 2025 22:57
@marksvc marksvc restored the task/draft-jobs-tests branch October 31, 2025 22:54
@marksvc marksvc deleted the task/draft-jobs-tests branch October 31, 2025 22:54
@marksvc marksvc restored the task/draft-jobs-tests branch October 31, 2025 22:57
@marksvc marksvc reopened this Oct 31, 2025
@marksvc marksvc force-pushed the task/draft-jobs-tests branch from 39d0ec8 to 36fc490 Compare October 31, 2025 22:58
@marksvc
Copy link
Collaborator Author

marksvc commented Oct 31, 2025

I am still in progress getting the tests to work after rebasing.

@marksvc marksvc force-pushed the task/draft-jobs-tests branch from 36fc490 to 33052a9 Compare November 3, 2025 17:06
@marksvc marksvc added the e2e Run e2e tests for this pull request label Nov 3, 2025
@marksvc marksvc removed the e2e Run e2e tests for this pull request label Nov 3, 2025
@marksvc marksvc force-pushed the task/draft-jobs-tests branch from 33052a9 to 9abbbbf Compare November 3, 2025 17:20
@marksvc marksvc closed this Nov 3, 2025
@marksvc marksvc deleted the task/draft-jobs-tests branch November 3, 2025 17:21
@marksvc marksvc restored the task/draft-jobs-tests branch November 3, 2025 17:21
@marksvc marksvc reopened this Nov 3, 2025
@marksvc marksvc marked this pull request as ready for review November 3, 2025 17:32
@marksvc marksvc marked this pull request as draft November 3, 2025 18:32
@marksvc marksvc force-pushed the task/draft-jobs-tests branch from 9abbbbf to b16996e Compare November 3, 2025 18:56
@marksvc marksvc closed this Nov 3, 2025
@marksvc marksvc deleted the task/draft-jobs-tests branch November 3, 2025 18:58
@marksvc marksvc restored the task/draft-jobs-tests branch November 3, 2025 18:58
@marksvc marksvc reopened this Nov 3, 2025
@marksvc marksvc force-pushed the task/draft-jobs-tests branch from b16996e to 85e5e48 Compare November 3, 2025 18:59
@marksvc marksvc changed the title sa: detect faulted job, add draft-jobs.component tests serval admin: detect faulted job, add draft-jobs.component tests Nov 3, 2025
@marksvc
Copy link
Collaborator Author

marksvc commented Nov 3, 2025

I think the event logger may be mistakenly mixing up SF project ids and SF user ids sometimes.

`BuildCompletedAsync` occurs and can alert about a Faulted job. Its sf
project id is in payload.
@marksvc marksvc force-pushed the task/draft-jobs-tests branch from 85e5e48 to 72e2b2d Compare November 3, 2025 19:04
@marksvc marksvc closed this Nov 3, 2025
@marksvc marksvc deleted the task/draft-jobs-tests branch November 3, 2025 19:04
@marksvc marksvc restored the task/draft-jobs-tests branch November 3, 2025 19:05
@marksvc marksvc reopened this Nov 3, 2025
@marksvc marksvc added the e2e Run e2e tests for this pull request label Nov 3, 2025
@marksvc marksvc marked this pull request as ready for review November 3, 2025 19:15
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 4 of 4 files at r1, 3 of 3 files at r3, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @marksvc)

@pmachapman pmachapman changed the title serval admin: detect faulted job, add draft-jobs.component tests Serval Admin: Detect faulted job, add draft-jobs.component tests Nov 3, 2025
@pmachapman pmachapman merged commit 12516bc into master Nov 3, 2025
51 of 53 checks passed
@pmachapman pmachapman deleted the task/draft-jobs-tests branch November 3, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants