-
-
Notifications
You must be signed in to change notification settings - Fork 5
SF-3519 Add notice about draft options #3500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3500 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 614 614
Lines 36885 36886 +1
Branches 6051 6051
=======================================
+ Hits 30361 30362 +1
+ Misses 5642 5629 -13
- Partials 882 895 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm the notice will only be visible for 2 weeks?
@pmachapman reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
c7a821b
to
0bdf84e
Compare
When you put it that way it's definitely too short. Pushed the timeline out another month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmachapman reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
0bdf84e
to
e2f226a
Compare
e2f226a
to
5b5e04c
Compare
This should not be merged until the page it links to actually exist. Opening this PR now so it can hopefully go live with our next release.
Currently
do not merge
is set on this PR because it's linking to a help page that does not yet exist.This change is