Skip to content

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Oct 8, 2025

This should not be merged until the page it links to actually exist. Opening this PR now so it can hopefully go live with our next release.

Currently do not merge is set on this PR because it's linking to a help page that does not yet exist.


This change is Reviewable

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.31%. Comparing base (75fcc56) to head (5b5e04c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3500   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         614      614           
  Lines       36885    36886    +1     
  Branches     6051     6051           
=======================================
+ Hits        30361    30362    +1     
+ Misses       5642     5629   -13     
- Partials      882      895   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman added the wait for next release Should not be merged until after the next release label Oct 8, 2025
@pmachapman pmachapman self-requested a review October 8, 2025 22:27
@pmachapman pmachapman self-assigned this Oct 8, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Just to confirm the notice will only be visible for 2 weeks?

@pmachapman reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@Nateowami Nateowami force-pushed the feature/SF-3519-add-draft-options-banner branch from c7a821b to 0bdf84e Compare October 8, 2025 22:32
@Nateowami
Copy link
Collaborator Author

When you put it that way it's definitely too short. Pushed the timeline out another month.

Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

@pmachapman reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@Nateowami Nateowami added the do not merge See PR description and/or comments for explanation label Oct 8, 2025
@Nateowami Nateowami force-pushed the feature/SF-3519-add-draft-options-banner branch from 0bdf84e to e2f226a Compare October 10, 2025 15:18
@Nateowami Nateowami force-pushed the feature/SF-3519-add-draft-options-banner branch from e2f226a to 5b5e04c Compare October 10, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge See PR description and/or comments for explanation testing not required wait for next release Should not be merged until after the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants