SF-3597 Enable draft options feature flag and remove beta label

[Nateowami]

Creating this PR a little before we're actually ready to merge it (there are outstanding changes to merge before we enable this feature), in hopes of having it reviewed and ready to test sooner.

---

This change is 

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.30%. Comparing base (f32232f) to head (1eac8a5).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3499      +/-   ##
==========================================
- Coverage   82.31%   82.30%   -0.01%     
==========================================
  Files         613      613              
  Lines       36877    36877              
  Branches     6022     6041      +19     
==========================================
- Hits        30354    30352       -2     
+ Misses       5642     5629      -13     
- Partials      881      896      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pmachapman]

Looks good. Just one minor comment!

@pmachapman reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)

---

src/SIL.XForge.Scripture/ClientApp/src/app/navigation/navigation.component.scss line 99 at r1 (raw file):

}

.nav-label {

.nav-label also appears in the block:

  &.activated-nav-item,
  &.active {
    background-color: var(--sf-navigation-list-item-active-background-color);
    --mdc-list-list-item-label-text-color: var(--sf-navigation-list-item-active);
    --mdc-list-list-item-hover-label-text-color: var(--sf-navigation-list-item-active);
    --mdc-list-list-item-focus-label-text-color: var(--sf-navigation-list-item-active);
    .nav-label {
      background-color: var(--sf-navigation-list-item-active);
      color: var(--sf-navigation-list-item-active-background-color);
    }
  }

Do you want to remove it there also?

Code quote:

.nav-label {

[Nateowami]

Thanks for the catch. Why did you add wait for next release? We're waiting on another PR, not the next release.

[Nateowami]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @pmachapman)

---

src/SIL.XForge.Scripture/ClientApp/src/app/navigation/navigation.component.scss line 99 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

.nav-label also appears in the block:

  &.activated-nav-item,
  &.active {
    background-color: var(--sf-navigation-list-item-active-background-color);
    --mdc-list-list-item-label-text-color: var(--sf-navigation-list-item-active);
    --mdc-list-list-item-hover-label-text-color: var(--sf-navigation-list-item-active);
    --mdc-list-list-item-focus-label-text-color: var(--sf-navigation-list-item-active);
    .nav-label {
      background-color: var(--sf-navigation-list-item-active);
      color: var(--sf-navigation-list-item-active-background-color);
    }
  }

Do you want to remove it there also?

Done.

[pmachapman]

Why did you add wait for next release? We're waiting on another PR, not the next release.

@Nateowami Just to stop an accidental merge by someone else. You can remove it if you like (it was the closest tag I could think of to the concept of waiting for another PR) I have removed it...the will require testing is sufficient...sorry I was overthinking!

[Nateowami]

@pmachapman Should we have a "don't merge" label and then explain why in the PR?

[pmachapman]

Should we have a "don't merge" label and then explain why in the PR?

We can...Maybe the chat history will be enough! Sorry for the distraction!

[Nateowami]

Not a problem; label created.

[pmachapman]

@pmachapman reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)