-
-
Notifications
You must be signed in to change notification settings - Fork 5
Update Serval.Client to 1.12 #3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3495 +/- ##
==========================================
+ Coverage 82.21% 82.23% +0.02%
==========================================
Files 615 615
Lines 37031 37076 +45
Branches 6068 6066 -2
==========================================
+ Hits 30444 30489 +45
Misses 5690 5690
Partials 897 897 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmachapman dismissed @github-advanced-security[bot] from 6 discussions.
Reviewable status: 0 of 8 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nateowami reviewed 6 of 8 files at r1, all commit messages.
Reviewable status: 6 of 8 files reviewed, 1 unresolved discussion
src/SIL.XForge.Scripture/Services/PreTranslationService.cs line 217 at r1 (raw file):
textOrigin: PretranslationUsfmTextOrigin.OnlyPretranslated, template: PretranslationUsfmTemplate.Source, paragraphMarkerBehavior: config.ParagraphFormat switch
Could we move these two switch expressions to before the if statement, so they're precomputed, and don't have to be manually kept in sync with each other, and reviewed to make sure they're the same? (in other words, calculate the paragraphMarkerBehavior and quoteNormalizationBehavior once rather than twice).
5714bd5 to
90c90f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @Nateowami)
src/SIL.XForge.Scripture/Services/PreTranslationService.cs line 217 at r1 (raw file):
Previously, Nateowami wrote…
Could we move these two switch expressions to before the if statement, so they're precomputed, and don't have to be manually kept in sync with each other, and reviewed to make sure they're the same? (in other words, calculate the paragraphMarkerBehavior and quoteNormalizationBehavior once rather than twice).
Done. That looks better - thanks!
90c90f3 to
aa22af2
Compare
This PR updates the Serval Client to version 1.12 (the version currently on QA).
This update to Serval.Client marks several the older corpus API endpoints as deprecated, so the code now clearly needs to demarcate whether a parallel corpus or a legacy corpus is being used to retrieve pre-translations.
This PR should only be merged when Serval 1.12 is deployed to production (likely later this week).
The current version of Serval.Client (1.10) will continue to work as per normal when Serval production is updated, so this PR is not a blocker in any way.
This change is