Skip to content

Conversation

RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Sep 16, 2025

This PR adds guidance to the user to select formatting options for their draft from the generated draft tab. The "apply to project" button will be disabled as long as the user has not selected formatting options for their project. Once options have been selected, they can add drafts to their project from the generated drafts tab.

Select formatting primary draft tab

This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Sep 16, 2025
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.20%. Comparing base (702a6f8) to head (6f7bff2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...late/editor/editor-draft/editor-draft.component.ts 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3447   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files         611      611           
  Lines       36434    36437    +3     
  Branches     6004     6005    +1     
=======================================
+ Hits        29951    29954    +3     
- Misses       5609     5622   +13     
+ Partials      874      861   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 force-pushed the fix/SF-3566-guide-formatting branch from b704c52 to 838fade Compare September 16, 2025 20:29
@pmachapman pmachapman self-requested a review September 24, 2025 05:55
@pmachapman pmachapman self-assigned this Sep 24, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Sep 24, 2025
@RaymondLuong3 RaymondLuong3 force-pushed the fix/SF-3566-guide-formatting branch from 838fade to 1a825f6 Compare September 24, 2025 17:25
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)

@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Sep 25, 2025
@Nateowami Nateowami force-pushed the fix/SF-3566-guide-formatting branch from 1a825f6 to 2249bf1 Compare September 25, 2025 13:39
@Nateowami Nateowami enabled auto-merge (squash) September 25, 2025 13:40
@Nateowami Nateowami force-pushed the fix/SF-3566-guide-formatting branch from 2249bf1 to 6f7bff2 Compare September 25, 2025 15:46
@Nateowami Nateowami merged commit 0e369e2 into master Sep 25, 2025
22 of 23 checks passed
@Nateowami Nateowami deleted the fix/SF-3566-guide-formatting branch September 25, 2025 15:54
josephmyers added a commit that referenced this pull request Oct 7, 2025
josephmyers added a commit that referenced this pull request Oct 7, 2025
josephmyers added a commit that referenced this pull request Oct 7, 2025
josephmyers added a commit that referenced this pull request Oct 8, 2025
josephmyers added a commit that referenced this pull request Oct 8, 2025
pmachapman pushed a commit that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants