Use non-CUDA Ubuntu Docker image #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac091
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
clearml_connection.py is still using the CUDA image, but I assume that change will come with the updates to get rid of the setup time on ClearML?
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mshannon-sil)
mshannon-sil
commented
Sep 30, 2024
There was a problem hiding this comment.
Yeah, and that work is all done as well. I'm submitting that PR once this is merged in and I've run one final test with the new SILNLP docker image.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the Dockerfiles to use the image
ubuntu:20.04rather than12.1.1-cudnn8-runtime-ubuntu20.04, since pytorch already comes with CUDA. I tested that experiments ran successfully in both Dockerfiles, and I tested locally and using a ClearML agent. Once the PR is merged, I'll add a tag to create the new SILNLP docker container.This change is