Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of core libraries including: #487

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Sep 11, 2024

  • MongoDB
  • Dotnet 6.x -> 8.x
  • Health checks
  • Grpc

This may resolve some of the intermittent error issues.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.15%. Comparing base (af05a06) to head (74b5cea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files         277      277           
  Lines       14150    14150           
  Branches     1900     1900           
=======================================
  Hits         8088     8088           
  Misses       5474     5474           
  Partials      588      588           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


src/ServiceToolkit/src/SIL.ServiceToolkit/SIL.ServiceToolkit.csproj line 14 at r1 (raw file):

	<ItemGroup>
	  <PackageReference Include="Bugsnag.AspNet.Core" Version="3.1.0" />

We aren't using this yet.

* MongoDB
* Dotnet 6.x -> 8.x
* Health checks
* Grpc
@johnml1135
Copy link
Collaborator Author

src/ServiceToolkit/src/SIL.ServiceToolkit/SIL.ServiceToolkit.csproj line 14 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

We aren't using this yet.

Done.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 2da4beb into main Sep 11, 2024
3 checks passed
@johnml1135 johnml1135 deleted the update_versions branch September 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants