-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create script to pull all Paratext projects for testing #432
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 61.73% 61.73%
=======================================
Files 232 232
Lines 11825 11825
Branches 1510 1510
=======================================
Hits 7300 7300
Misses 3998 3998
Partials 527 527 ☔ View full report in Codecov by Sentry. |
files may have the same name, but you don't know if they are the same file or not. There probably is a magical way for accounting for this, such as, if the files are the same size, just ignore the new file, but if they have a different size, create a new file with a different name, etc. |
Previously, johnml1135 (John Lambert) wrote…
I am afraid of 500 files being named Paratext.zip ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)
scripts/pull_all_usfm.py
line 40 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
I am afraid of 500 files being named Paratext.zip ...
That's a good catch. I think the SF procedure uses unique ids, so it shouldn't matter, but better to generalize it. Done: I did <name>_<id>
in order to preserve alphabetic ordering and readability.
Previously, Enkidu93 (Eli C. Lowry) wrote…
Will the files still be usable by the machine "parse everything" script? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)
scripts/pull_all_usfm.py
line 40 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Will the files still be usable by the machine "parse everything" script?
Yep, it doesn't care what they're named.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
Addresses #429
This change is