Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message regarding too many builds #430

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jul 11, 2024

(Continuation of Jonathan Hudlow's request)


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from johnml1135 July 11, 2024 14:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (e6b763b) to head (59db438).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   61.73%   61.73%           
=======================================
  Files         232      232           
  Lines       11825    11825           
  Branches     1510     1510           
=======================================
  Hits         7300     7300           
  Misses       3998     3998           
  Partials      527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

:lgtm:

@johnml1135
Copy link
Collaborator

@Enkidu93 - can you resolve the conflicting files?

@Enkidu93
Copy link
Collaborator Author

@Enkidu93 - can you resolve the conflicting files?

Done.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135
Copy link
Collaborator

:lgtm:

@johnml1135 johnml1135 merged commit de63abc into main Jul 11, 2024
2 checks passed
@Enkidu93 Enkidu93 deleted the serval_app_remove_per_client_limit branch August 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants