Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "UseSourceUsfm" option to USFM endpoint. #420

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jul 3, 2024

fixes #405.


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit July 3, 2024 00:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.62500% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (c149d4b) to head (158a990).

Files Patch % Lines
src/Serval/src/Serval.Client/Client.g.cs 0.00% 3 Missing and 1 partial ⚠️
...rval.Translation/Services/PretranslationService.cs 96.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   71.19%   71.18%   -0.02%     
==========================================
  Files         151      151              
  Lines        7184     7195      +11     
  Branches     1126     1129       +3     
==========================================
+ Hits         5115     5122       +7     
- Misses       1612     1615       +3     
- Partials      457      458       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 8d24eff into main Jul 5, 2024
2 checks passed
@johnml1135 johnml1135 deleted the source_only branch July 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choice to always use source USFM for generating new USFM
3 participants