Only allow textId or scriptureRange in a buildID. (#401)

* one, but not both. * from review
sillsdev · Jun 10, 2024 · 68a0374 · 68a0374
1 parent 7dcbb5c
commit 68a0374
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/Serval.Translation/Services/EngineService.cs b/src/Serval.Translation/Services/EngineService.cs
@@ -232,6 +232,12 @@ Dictionary<string, List<int>> GetChapters(V1.Corpus corpus, string scriptureRang
                         {
                             corpus.PretranslateAll =
                                 pretranslateCorpus.TextIds is null && pretranslateCorpus.ScriptureRange is null;
+                            if (pretranslateCorpus.TextIds is not null && pretranslateCorpus.ScriptureRange is not null)
+                            {
+                                throw new InvalidOperationException(
+                                    $"The corpus {c.Id} cannot specify both 'textIds' and 'scriptureRange' for 'pretranslate'."
+                                );
+                            }
                             if (pretranslateCorpus.TextIds is not null)
                                 corpus.PretranslateTextIds.Add(pretranslateCorpus.TextIds);
                             if (!string.IsNullOrEmpty(pretranslateCorpus.ScriptureRange))
@@ -262,6 +268,12 @@ Dictionary<string, List<int>> GetChapters(V1.Corpus corpus, string scriptureRang
                         if (trainOn?.TryGetValue(c.Id, out TrainingCorpus? trainingCorpus) ?? false)
                         {
                             corpus.TrainOnAll = trainingCorpus.TextIds is null && trainingCorpus.ScriptureRange is null;
+                            if (trainingCorpus.TextIds is not null && trainingCorpus.ScriptureRange is not null)
+                            {
+                                throw new InvalidOperationException(
+                                    $"The corpus {c.Id} cannot specify both 'textIds' and 'scriptureRange' for trainOn"
+                                );
+                            }
                             if (trainingCorpus.TextIds is not null)
                                 corpus.TrainOnTextIds.Add(trainingCorpus.TextIds);
                             if (!string.IsNullOrEmpty(trainingCorpus.ScriptureRange))