Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete handling of \d marker #216

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Jun 24, 2024


This change is Reviewable

- fixes sillsdev/serval#416
- add UsfmMemoryText for testing
- add support for isolated testing of USFM parsing/generation
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@4e88953). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #216   +/-   ##
=========================================
  Coverage          ?   67.30%           
=========================================
  Files             ?      447           
  Lines             ?    35433           
  Branches          ?     4736           
=========================================
  Hits              ?    23849           
  Misses            ?    10496           
  Partials          ?     1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135 johnml1135 self-requested a review June 24, 2024 17:28
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit ceb586c into master Jun 24, 2024
4 checks passed
@johnml1135 johnml1135 deleted the descriptive-title branch June 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USFM ScriptureTag emtpyStack
3 participants