Extract language tags from FLEx projects and store in DB metadata #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't store anything in the DB yet.
We skip pronunciation since it's a subset of vernacular and we don't need it. We load all vern/analysis, and current vern/analysis.
This can go in another PR
Migration will be in the next commit.
VernacularAndAnalysisLangTags now returns two lists of FLExWsId objects with the IsActive properties set, rather than four arrays of strings.
rmunn
commented
Jul 12, 2024
|
Actually, now that I take another look at #922 this doesn't yet do everything the issue asks for. For example, there's no GraphQL filtering available yet. Marking as draft and removing review request for now. |
UI unit Tests11 tests 11 ✅ 0s ⏱️ Results for commit 388e474. ♻️ This comment has been updated with latest results. |
While we're adding hg runner commands, we can easily add one to extract the GUID from the LangProject element, which may allow identifying projects which started out as copies of each other even though their Mercurial repo histories have no common commits.
Also include a DB migration and GQL schema update
Since we're using `\K`, a rarely-used feature, we should explain it.
The XML element is named VernWss, not VernVss.
The order in which FLEx returns writing systems is current first, then all non-current (if any) at the end. We want what we store in the project metadata to match that ordering.
rmunn
commented
Jul 15, 2024
hahn-kev
requested changes
Jul 16, 2024
backend/LexData/Migrations/20240715044054_AddIsDefaultFieldToFLExWsId.cs
Outdated
Show resolved
Hide resolved
frontend/src/routes/(authenticated)/project/[project_code]/+page.svelte
Outdated
Show resolved
Hide resolved
frontend/src/routes/(authenticated)/project/[project_code]/+page.svelte
Outdated
Show resolved
Hide resolved
Eventually these tests should clean up after themselves, or use randomly-assigned project codes so that they don't conflict. But for now this is good enough for a quick fix.
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #922.
This PR extracts language tags from FLEx projects, but does nothing yet to validate or process them. That might come in a separate PR; this one just stores the language tag data into a JSON column and leaves the analysis for later.