add health check for hgweb to match api version

[hahn-kev]

this adds a health check to the api so when /api/healthz is called it verifies that hgweb is running the same version, if it's not then the health is degraded.

todo:

• disable in develop
• fix the deploy script to fail deployments that never become healthy.

closes #672

[github-actions]

C# Unit Tests

35 tests   35 ✅  4s ⏱️
 8 suites   0 💤
 1 files     0 ❌

Results for commit 899e635.

♻️ This comment has been updated with latest results.

[myieye]

It won't work properly in develop, because we only deploy what changed, is that right?
So, either:

1. A PR changed both and they have the same version
2. A PR only changes 1, which should indicate that the new version of that is compatible with the old version of the other

So, yeah, disabling it in develop sounds good to me.

[hahn-kev]

Yeah that's right about develop, we only push the changes that were made.

[myieye]

So, it seems to be working, but what do we get out of this?

[lexbox-api] warn: Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService[103]
[lexbox-api]       => TraceId:fd6314267ee0210d42d107a3b5fbc5f7 => ConnectionId:0HN2JQPNPPUSR => RequestPath:/api/healthz RequestId:0HN2JQPNPPUSR:00000001 => Microsoft.Extensions.Diagnostics.HealthChecks.HealthCheckLogScope
[lexbox-api]       Health check hgweb with status Degraded completed after 50.4235ms with message 'api version: 'dockerDev' hg version: 'dockerDev2' mismatch'

I don't see the degraded status anywhere in k8s and it deploys the version regardless of the health being degraded. What do we want to happen?

[hahn-kev]

that's a good point, my thinking was that the deploy script would catch it, but right now it only checks the version header and not the status code to see the response. Need to fix the script to keep trying until the service is healthy

[github-actions]

UI unit Tests

11 tests   11 ✅  0s ⏱️
 3 suites   0 💤
 1 files     0 ❌

Results for commit 899e635.

♻️ This comment has been updated with latest results.

[rmunn]

LGTM.