Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open with FLEx button #442

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Add Open with FLEx button #442

merged 2 commits into from
Jan 19, 2024

Conversation

josephmyers
Copy link
Collaborator

No description provided.

@josephmyers josephmyers linked an issue Nov 30, 2023 that may be closed by this pull request
@josephmyers
Copy link
Collaborator Author

@myieye Kevin mentioned you finishing out the GUI work for this task. Cool beans?

We also shouldn't merge this until we get a release of FLEx with my changes. I'm following up on getting some sort of a beta release right now

@myieye
Copy link
Contributor

myieye commented Nov 30, 2023

@myieye Kevin mentioned you finishing out the GUI work for this task. Cool beans?

We also shouldn't merge this until we get a release of FLEx with my changes. I'm following up on getting some sort of a beta release right now

@josephmyers You're alive 🎉. That's the first I've heard of me doing GUI work for this 😆. Perhaps my memory fails me. I'd enjoy it, so 🤷

@hahn-kev
Copy link
Collaborator

The UI is more or less done, but I wanted to let you have a pass at it, and possibly the UX of it too, I'll take a look when I get a chance also.

Copy link

github-actions bot commented Dec 7, 2023

UI unit Tests

1 tests  ±0   1 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 40d562a. ± Comparison against base commit bfebaa8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

C# Unit Tests

39 tests   39 ✅  5s ⏱️
 7 suites   0 💤
 1 files     0 ❌

Results for commit 40d562a.

♻️ This comment has been updated with latest results.

@myieye
Copy link
Contributor

myieye commented Jan 16, 2024

  • Rebased onto develop
  • Made use of Daisy 4 e04ffc4
  • Removed added, unused parameter b3ca963

@hahn-kev
Copy link
Collaborator

I want to merge this in, but I feel like I want to do #477 first so we can only show this button to us. Maybe we need a feature flag system.

@hahn-kev
Copy link
Collaborator

implemented the dev mode as a simple local storage value, with a global function we can call from the console. This is ready to merge now.

@hahn-kev hahn-kev marked this pull request as ready for review January 19, 2024 06:54
@hahn-kev hahn-kev enabled auto-merge (rebase) January 19, 2024 06:54
@myieye
Copy link
Contributor

myieye commented Jan 19, 2024

I squashed virtually all the commits so that the rebase was easier.

Everything seems to be working:
image

Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephmyers @hahn-kev 🎉
Yay team! Today's the day! 😄

....not the day users can start using it, but.............meh.

@hahn-kev hahn-kev merged commit fe46a20 into develop Jan 19, 2024
11 checks passed
@myieye myieye deleted the open-with-flex branch January 19, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add open with FLEx button
3 participants