Provide more info when Cloudflare test fails #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In most cases the body is going to be just the health response so I see no reason why we can't read it. That said cloudflare doesn't really tell you why it failed, this is their response when I bump up the header size: |
myieye
force-pushed
the
test/provide-more-info-when-cloudflare-test-fails
branch
from
070bf54
to
43e7cff
Compare
myieye
force-pushed
the
test/provide-more-info-when-cloudflare-test-fails
branch
from
43e7cff
to
46e5f60
Compare
|
@hahn-kev how's that? |
|
Weird, why isn't it consistent? Oh well, that'll work. Nice job Tim. |
hahn-kev
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failed here: https://github.com/sillsdev/languageforge-lexbox/actions/runs/7031506840/job/19133260117
I'm not sure if this change is what we want or if we should put it in an
ifso that we don't always read the content or if we should just bump the header size down a bit.