Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/trace user #435

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Chore/trace user #435

merged 1 commit into from
Nov 29, 2023

Conversation

hahn-kev
Copy link
Collaborator

there are times when it would be useful to group telemetry queries by user id, but we can't do that for traces where the user id doesn't exist. This is an attempt to add it to all our traces.

@hahn-kev hahn-kev requested a review from myieye November 29, 2023 09:25
Copy link

github-actions bot commented Nov 29, 2023

UI unit Tests

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit ca5a873. ± Comparison against base commit 634e4e1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2023

C# Unit Tests

37 tests   37 ✔️  5s ⏱️
  7 suites    0 💤
  1 files      0

Results for commit ca5a873.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a much more harmless change than my suggestion 😆

@hahn-kev hahn-kev merged commit 056e43d into develop Nov 29, 2023
11 checks passed
@myieye myieye deleted the chore/trace-user-id branch November 30, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants