Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from svelte-markdown to svelte-exmarkdown #432

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Migrate from svelte-markdown to svelte-exmarkdown #432

merged 1 commit into from
Nov 29, 2023

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Nov 28, 2023

Fixes #418

Reasons this is a good change:

  • svelte-exmarkdown is more active
  • svelte-exmarkdown doesn't need to suppress warnings (in fact the warnings that svelte-markdown suppresses are good and meaningful svelte-exmarkdown. They helped me fix our NewTabLinkRenderer

I viewed all the markdown we're currently rendering and it looks the same.

@github-actions GitHub Actions
Copy link

UI unit Tests

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit afb95fb. ± Comparison against base commit 84a2fe6.

hahn-kev
hahn-kev approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge it when ready

@myieye myieye merged commit 634e4e1 into develop Nov 29, 2023
6 checks passed
@myieye myieye deleted the 418-fix-markdown-library branch November 29, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahn-kev hahn-kev hahn-kev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Markdown library
2 participants
@myieye @hahn-kev