Complex forms and components UI #1121
Conversation
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit 679571d. ♻️ This comment has been updated with latest results. |
…ead pass them directly to where they need to go skipping the event handler
| <button slot="trigger" class="flex-1 flex justify-between items-center text-left max-w-full overflow-hidden" | ||
| on:click={() => { | ||
| if (disableExpand && !disabledEntry) { | ||
| // the change event above is not in use, so we need to do it here |
There was a problem hiding this comment.
is this comment still correct? if I remove on:change from the Expansion panel then the sections don't get highlighted correctly
There was a problem hiding this comment.
The comment is valid in the context of the if it's inside.
There was a problem hiding this comment.
Actually, only this part: if (disableExpand).
The disabledEntry part should probably just set the disabled attribute of the button it's on.
| <Button disabled on:click={() => openPicker = true} icon={mdiPlus} variant="fill-light" color="success" size="sm"> | ||
| <div class="max-sm:hidden">Add Complex Form Type</div> | ||
| </Button> | ||
| <!-- TODO: implement form type picker or dropdown? <EntryOrSensePicker title="Add complex form" bind:open={openPicker} noSenses on:pick={(e) => addComplexFormType(e.detail)} /> --> |
There was a problem hiding this comment.
looks like this was forgotten. Still need to have a pick for the form type
There was a problem hiding this comment.
Yeah, I'd like to do that in a follow up PR.
Resolves most of #1089