-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write about page #1104
Write about page #1104
Conversation
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit 40c34c2. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I like the mention of open source 👍.
- It feels weird to mention SIL Lexical Tools by itself, because it sort of excludes Payap. We could somehow squash it into our mention of Language Technology, but I'm not sure if it's worth it.
Then it looks like you took the homescreen text and made some changes to it. Here are my observations:
- You removed WeSay. How come? I know it's old, but...
- There's a pronoun change that doesn't work: "We host..." to "It is..."
- "the Linguistics Institute..." sounds better to me. I think the article should be there.
Ultimately, I like the home page version more. I'd just take that and add your open source line. I wouldn't necessarily include the open source mention on the home page (we sure can if you'd prefer), but other than that, it would be handy if we can share the same i18n text.
Yeah I kinda just let AI complete it for me, so that's why it looks weird. I agree, let's just reuse the home version and update it. |
…open source in the welcome text
@hahn-kev FYI, I changed it to a |
closes #854
For now I'm just going to write it in english to keep it simple. @myieye would you take a look even though it's still a draft?