Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write about page #1104

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Write about page #1104

merged 4 commits into from
Oct 16, 2024

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Oct 7, 2024

closes #854

For now I'm just going to write it in english to keep it simple. @myieye would you take a look even though it's still a draft?

Copy link

github-actions bot commented Oct 7, 2024

UI unit Tests

12 tests   12 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 40c34c2.

♻️ This comment has been updated with latest results.

@hahn-kev hahn-kev requested a review from myieye October 7, 2024 08:28
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I like the mention of open source 👍.
  • It feels weird to mention SIL Lexical Tools by itself, because it sort of excludes Payap. We could somehow squash it into our mention of Language Technology, but I'm not sure if it's worth it.

Then it looks like you took the homescreen text and made some changes to it. Here are my observations:

  • You removed WeSay. How come? I know it's old, but...
  • There's a pronoun change that doesn't work: "We host..." to "It is..."
  • "the Linguistics Institute..." sounds better to me. I think the article should be there.

Ultimately, I like the home page version more. I'd just take that and add your open source line. I wouldn't necessarily include the open source mention on the home page (we sure can if you'd prefer), but other than that, it would be handy if we can share the same i18n text.

@hahn-kev
Copy link
Collaborator Author

hahn-kev commented Oct 9, 2024

Yeah I kinda just let AI complete it for me, so that's why it looks weird.

I agree, let's just reuse the home version and update it.

@hahn-kev hahn-kev marked this pull request as ready for review October 15, 2024 06:59
@myieye
Copy link
Contributor

myieye commented Oct 15, 2024

@hahn-kev FYI, I changed it to a <TitlePage>, because I think that's more consistent with our design. 🤷
Made a few other small changes too:

image

@hahn-kev hahn-kev merged commit c68820f into develop Oct 16, 2024
6 checks passed
@hahn-kev hahn-kev deleted the chore/write-about branch October 16, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create about page for lexbox
2 participants