Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement project reset cleanup #1070

Merged
merged 2 commits into from
Sep 27, 2024
Merged

implement project reset cleanup #1070

merged 2 commits into from
Sep 27, 2024

Conversation

hahn-kev
Copy link
Collaborator

closes #663

this works by parsing the folder names in the deleted folder and pulling out the timestamp. If it can't get a time stamp it does nothing, if it can then it will make sure the project was reset greater than the cleanup threshold (default 31 days).

Right now this only cleans up reset project backups. Should we also include normal deleted projects and do they need a different threshold?

Copy link

github-actions bot commented Sep 25, 2024

C# Unit Tests

71 tests  +5   71 ✅ +5   5s ⏱️ -1s
12 suites +1    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 883bad0. ± Comparison against base commit a84e265.

♻️ This comment has been updated with latest results.

myieye
myieye previously approved these changes Sep 25, 2024
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My manual test using the testing endpoint was successful. I ran a dry run and then a wet run:
image

backend/LexCore/Utils/FileUtils.cs Outdated Show resolved Hide resolved
@myieye
Copy link
Contributor

myieye commented Sep 25, 2024

As a reminder:
As discussed at our meeting today, @hahn-kev wants to test our backups and then extend this logic to also delete deleted projects that are 31 days old.

@hahn-kev hahn-kev merged commit 424fdfe into develop Sep 27, 2024
8 checks passed
@hahn-kev hahn-kev deleted the chore/663-cleanup-reset branch September 27, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up repos in _____deleted_____
2 participants