Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini lcm refactor #1046

Merged
merged 9 commits into from
Sep 25, 2024
Merged

mini lcm refactor #1046

merged 9 commits into from
Sep 25, 2024

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Sep 2, 2024

mini LCM calls it's main api ILexboxApi which is a poor name, so I've renamed it and split it into a read and write api.

@hahn-kev hahn-kev marked this pull request as ready for review September 24, 2024 01:49
# Conflicts:
#	backend/FwLite/LocalWebApp/Hubs/CrdtMiniLcmApiHub.cs
#	backend/LfClassicData/LfClassicRoutes.cs
Copy link

github-actions bot commented Sep 24, 2024

C# Unit Tests

66 tests  ±0   66 ✅ ±0   6s ⏱️ ±0s
11 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4c8f8ac. ± Comparison against base commit 7aafe1a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I appreciate the rename, namespace moving and split into Read & Write APIs 👍

@hahn-kev hahn-kev merged commit a84e265 into develop Sep 25, 2024
14 checks passed
@hahn-kev hahn-kev deleted the chore/mini-lcm-refactor branch September 25, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants