Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide members of confidential projects #1031

Merged
merged 8 commits into from
Sep 27, 2024

Commits on Sep 24, 2024

  1. Hide members of confidential projects

    Only the following people can see the list of members if a project is
    confidential: the manager(s) of the project, site admins, and the org
    admin(s) of the org(s) the project belongs to, if any. Everyone else,
    including people who are themselves members of the project, cannot see
    its membership.
    rmunn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1aff610 View commit details
    Browse the repository at this point in the history
  2. Hide members list of confidential projects

    GQL query will return an empty users list if you're not allowed to see
    the project members.
    rmunn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    932c33c View commit details
    Browse the repository at this point in the history
  3. Address review comments

    rmunn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b31f319 View commit details
    Browse the repository at this point in the history
  4. Simplify code with null-coalescing expression

    As suggested by C# builtin code analyzer.
    rmunn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d82dc88 View commit details
    Browse the repository at this point in the history
  5. Change confidentiality default for project members

    For project members, and ONLY for project members, we will default to
    showing them for projects whose confidentiality has not been set. This
    isn't the most secure default, but it will avoid what would likely be a
    lot of user confusion.
    rmunn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d2719fb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    078fc9c View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    0b65db2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7015d1 View commit details
    Browse the repository at this point in the history