Address review comments

sillsdev · Oct 15, 2024 · 59733e0 · 59733e0
1 parent 21d089e
commit 59733e0
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 14 deletions.
diff --git a/backend/LexBoxApi/GraphQL/ProjectMutations.cs b/backend/LexBoxApi/GraphQL/ProjectMutations.cs
@@ -425,8 +425,6 @@ public async Task<IQueryable<Project>> UpdateFLExModelVersion(string code,
     {
         var projectId = await projectService.LookupProjectId(code);
         await permissionService.AssertCanManageProject(projectId);
-        var project = await dbContext.Projects.FindAsync(projectId);
-        NotFoundException.ThrowIfNull(project);
         await projectService.UpdateFLExModelVersion(projectId);
         return dbContext.Projects.Where(p => p.Id == projectId);
     }

diff --git a/backend/LexBoxApi/Services/HgService.cs b/backend/LexBoxApi/Services/HgService.cs
@@ -271,16 +271,8 @@ private string[] GetWsList(System.Xml.XmlElement root, string tagName)
     {
         var result = await ExecuteHgCommandServerCommand(code, "flexmodelversion", token);
         var text = await result.ReadAsStringAsync(token);
-        try
-        {
-            var json = JsonDocument.Parse(text);
-            return json.RootElement.GetProperty("modelversion").GetInt32();
-        }
-        catch
-        {
-            if (int.TryParse(text, out var num)) return num;
-        }
-        return null;
+        var json = JsonDocument.Parse(text);
+        return json.RootElement.GetProperty("modelversion").GetInt32();
     }
 
     public Task RevertRepo(ProjectCode code, string revHash)

diff --git a/frontend/src/lib/components/Projects/FlexModelVersionText.svelte b/frontend/src/lib/components/Projects/FlexModelVersionText.svelte
@@ -28,4 +28,4 @@
   $: fwModel = versionLookupTable[modelVersion] ?? 'Unknown FieldWorks version';
 </script>
 
-<span class={extraClass}>{fwModel}</span>
+<span title="FLEx data model {modelVersion}" class={extraClass}>{fwModel}</span>
diff --git a/frontend/src/routes/(authenticated)/project/[project_code]/+page.svelte b/frontend/src/routes/(authenticated)/project/[project_code]/+page.svelte
@@ -389,7 +389,6 @@
           </AdminContent>
         </DetailItem>
       {/if}
-      <!-- Only show model version to project managers and admins, too technical to show to regular members -->
       {#if project.type === ProjectType.FlEx}
         <DetailItem title={$t('project_page.model_version')}>
           <FlexModelVersionText modelVersion={flexModelVersion ?? 0} />