move integration tests into a reusable action to simplify testing the…

…m, introduce setup-python to install python v2 in the runner.

add taskfile for testing github actions

.github/Taskfile.yml

@@ -0,0 +1,5 @@
+version: 3
+tasks:
+  integration-test:
+    cmds:
+      - act -j integration-test -r

.github/actions/integration/action.yml

@@ -0,0 +1,30 @@
+name: "Run integration tests"
+
+inputs:
+  hostname:
+    description: "Target host to run the integration tests against"
+    required: true
+
+runs:
+  using: composite
+  steps:
+#     standard github setup python does not support version 2 anymore :(
+    - uses: MatteoH2O1999/setup-python@v1
+      with:
+        python-version: '2.x'
+    - name: Build dotnet
+      run: dotnet build
+    - name: Ensure browsers are installed
+      run: pwsh ./backend/Testing/bin/Debug/net7.0/playwright.ps1 install --with-deps
+    - name: Integration Test
+      env:
+        TEST_SERVER_HOSTNAME: ${{ inputs.hostname }}
+        TEST_STANDARD_HG_HOSTNAME: hg-${{ inputs.hostname }}
+        TEST_RESUMABLE_HG_HOSTNAME: resumable-${{ inputs.hostname }}
+      run: dotnet test --logger trx --results-directory ./testresults --filter "Category=Integration"
+    - name: Upload test results
+      uses: EnricoMi/publish-unit-test-result-action@v2
+      if: always() && !env.act
+      with:
+        check_name: Integration Test
+        files: ./testresults/*.trx

.github/workflows/action-testing.yaml

@@ -0,0 +1,11 @@
+on:
+  workflow_call:
+
+jobs:
+  integration-test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/actions/integration
+        with:
+          hostname: staging.languagedepot.org

.github/workflows/deploy.yaml

@@ -56,20 +56,7 @@ jobs:
           echo "Version $versionHeader is still incorrect after waiting"
           exit 1
       - uses: actions/checkout@v3
-      - name: Build dotnet
-        run: dotnet build
-      - name: Ensure browsers are installed
-        run: pwsh ./backend/Testing/bin/Debug/net7.0/playwright.ps1 install --with-deps
-      - name: Integration Test
-        env:
-          TEST_SERVER_HOSTNAME: staging.languagedepot.org
-          TEST_STANDARD_HG_HOSTNAME: hg-staging.languagedepot.org
-          TEST_RESUMABLE_HG_HOSTNAME: resumable-staging.languagedepot.org
-        run: dotnet test --logger trx --results-directory ./testresults --filter "Category=Integration"
-      - name: Upload test results
-        uses: EnricoMi/publish-unit-test-result-action@v2
-        if: always()
+      - uses: ./github/actions/integration
         with:
-          check_name: Integration Test
-          files: ./testresults/*.trx
+          hostname: staging.languagedepot.org
 

Taskfile.yml

@@ -9,6 +9,8 @@ includes:
   k8s:
     taskfile: ./deployment/Taskfile.yml
     dir: ./deployment
+  gh:
+    taskfile: ./.github/Taskfile.yml
 
 tasks:
   setup:

backend/Testing/Services/SendReceiveService.cs

@@ -22,12 +22,16 @@ public async Task<string> GetHgVersion()
         string output = "";
         using (Process hg = new()) {
             string hgFilename = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "hg.exe" : "hg";
-            hg.StartInfo.FileName = System.IO.Path.Join("Mercurial", hgFilename);
+            hg.StartInfo.FileName = Path.Join("Mercurial", hgFilename);
+            if (!File.Exists(hg.StartInfo.FileName))
+            {
+                throw new FileNotFoundException("unable to find HG executable", hg.StartInfo.FileName);
+            }
             hg.StartInfo.Arguments = "version";
             hg.StartInfo.RedirectStandardOutput = true;
 
             hg.Start();
-            output = hg.StandardOutput.ReadToEnd();
+            output = await hg.StandardOutput.ReadToEndAsync();
             await hg.WaitForExitAsync();
         }
         return output;

backend/Testing/SyncReverseProxy/SendReceiveServiceTests.cs

@@ -1,3 +1,4 @@
+using Chorus.VcsDrivers.Mercurial;
 using Microsoft.Extensions.Hosting;
 using Shouldly;
 using SIL.Progress;
@@ -8,7 +9,7 @@
 namespace Testing.SyncReverseProxy;
 
 [Trait("Category", "Integration")]
-public class SendReceiveServiceTests
+public class SendReceiveServiceTests : IAsyncLifetime
 {
     private string _basePath = Path.Join(Path.GetTempPath(), "SendReceiveTests");
     private IProgress _progress;
@@ -20,6 +21,16 @@ public SendReceiveServiceTests(ITestOutputHelper output)
         CleanUpTempDir();
     }
 
+    public async Task InitializeAsync()
+    {
+        await VerifyHgWorking();
+    }
+
+    public Task DisposeAsync()
+    {
+        return Task.CompletedTask;
+    }
+
     private void CleanUpTempDir()
     {
         var dirInfo = new DirectoryInfo(_basePath);
@@ -84,49 +95,34 @@ public void CloneProjectAndSendReceive(SendReceiveTestData data)
         string projectDir = Path.Join(_basePath, data.HostType, data.ProjectCode);
         string fwdataFile = Path.Join(projectDir, $"{data.ProjectCode}.fwdata");
         long oldLength = 0;
+        var fileInfo = new FileInfo(fwdataFile);
         try
         {
             string result = srService.CloneProject(data.ProjectCode, projectDir, data.Username, data.Password);
             if (data.ShouldPass)
             {
                 result.ShouldNotContain("abort");
                 result.ShouldNotContain("error");
+                fileInfo.Directory?.Exists.ShouldBeTrue("directory " + fileInfo.DirectoryName + " not found. Clone response: " + result);
+                fileInfo.Directory!.EnumerateFiles().ShouldContain(child => child.Name == fileInfo.Name);
                 fwdataFile.ShouldSatisfyAllConditions(
-                    () => new FileInfo(fwdataFile).Exists.ShouldBeTrue(),
-                    () => new FileInfo(fwdataFile).Length.ShouldBeGreaterThan(0)
+                    () => fileInfo.Exists.ShouldBeTrue(),
+                    () => fileInfo.Length.ShouldBeGreaterThan(0)
                 );
-                oldLength = new FileInfo(fwdataFile).Length;
+                oldLength = fileInfo.Length;
             }
             else
             {
                 result.ShouldMatch("abort: authorization failed|Server Response 'Unauthorized'");
             }
         }
-        catch (Chorus.VcsDrivers.Mercurial.RepositoryAuthorizationException)
+        catch (RepositoryAuthorizationException) when (!data.ShouldPass)
         {
-            if (data.ShouldPass)
-            {
-                throw;
-            }
-            else
-            {
-                // This is a successful test, because the repo rejected the invalid password as it should
-            }
-
-            ;
+            // This is a successful test, because the repo rejected the invalid password as it should
         }
-        catch (System.UnauthorizedAccessException)
+        catch (UnauthorizedAccessException) when (!data.ShouldPass)
         {
-            if (data.ShouldPass)
-            {
-                throw;
-            }
-            else
-            {
-                // This is a successful test, because the repo rejected the invalid password as it should
-            }
-
-            ;
+            // This is a successful test, because the repo rejected the invalid password as it should
         }
 
         // Now do a Send/Receive which should get no changes
@@ -140,8 +136,8 @@ public void CloneProjectAndSendReceive(SendReceiveTestData data)
                 result2.ShouldNotContain("error");
                 result2.ShouldContain("no changes from others");
                 fwdataFile.ShouldSatisfyAllConditions(
-                    () => new FileInfo(fwdataFile).Exists.ShouldBeTrue(),
-                    () => new FileInfo(fwdataFile).Length.ShouldBe(oldLength)
+                    () => fileInfo.Exists.ShouldBeTrue(),
+                    () => fileInfo.Length.ShouldBe(oldLength)
                 );
             }
             else