-
-
Notifications
You must be signed in to change notification settings - Fork 10
Lazy load language picker #3999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3999 +/- ##
==========================================
+ Coverage 74.57% 74.60% +0.03%
==========================================
Files 291 293 +2
Lines 10814 10818 +4
Branches 1354 1354
==========================================
+ Hits 8064 8071 +7
+ Misses 2358 2352 -6
- Partials 392 395 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bundle before and after:
|
|
How about LoadableLanguagePicker? When we provide translations it will be internal to this method, so the name should reflect the usage. |
|
Please make a new test for this behavior. Code quote: it("disables language picker(s) when file selected", async () => {
// Hides language pickers until project name is typed.
expect(screen.queryByTestId(mockLangPickerId)).toBeNull();
await userEvent.type(screen.getByRole("textbox"), "non-empty-name"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonleenaylor reviewed 5 of 5 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #3987
Lazy loads the 5+ MB language picker bundle piece, so it won't load for most user sessions.
Current "Create Project"
Without LIFT file selected

With LIFT file selected

Updated "Create Project"
When no project name is typed and no LIFT file is selected:

When a project name is typed first:

When a LIFT file is selected first:

This change is