Skip to content

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 31, 2025

Fixes #3987


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 31, 2025
@imnasnainaec imnasnainaec added bug Something isn't working 🟨Medium Medium-priority PR labels Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.40%. Comparing base (e5bccbb) to head (a448476).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Login/Signup.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3989   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files         291      291           
  Lines       10790    10790           
  Branches     1351     1351           
=======================================
  Hits         8028     8028           
  Misses       2373     2373           
  Partials      389      389           
Flag Coverage Δ
backend 85.45% <ø> (ø)
frontend 65.86% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 518adb0 into master Nov 3, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/sign-up-email-verify-no-email branch November 3, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend login/signUp 🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In dev, if email env vars not set, signup throw error

3 participants