-
-
Notifications
You must be signed in to change notification settings - Fork 10
[Statistics] Migrate from deprecated Grid and use a Table #3855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3855 +/- ##
==========================================
- Coverage 74.20% 74.19% -0.02%
==========================================
Files 288 288
Lines 10623 10617 -6
Branches 1323 1323
==========================================
- Hits 7883 7877 -6
Misses 2353 2353
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
That new grid looks much better than the old one! Especially on smaller screens. I don't know the react code enough to comment on it. Scope creep: the Data Cleanup button at 700px doesn't look great, could it just say "Cleanup"? |
|
Maybe add a comment here explaining that the query returns a row for each item and one row in the header? Same in the Statistics tests. |
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 7 files at r1, 3 of 4 files at r2, all commit messages.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @imnasnainaec)
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it doesn't look great when it's the only button to wrap to two lines, but handling that properly would require evaluating and/or limiting the string length in all UI languages, which isn't worth it at this time.
Reviewable status: 5 of 7 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Part of #3787
Notes for review:
<Grid>s and<Lists>s with some combination of<Grid2>s and <Table*>`s.npm startyou can simulate collection across multiple days by using MongoDB Compass to manually change the dates within CombineDatabase > FrontierCollection > query { projectId: "id-string-of-the-proj" } > pick a word > senses > [0] > SemanticDomains > [0] > created: "double-click-between-the-quotes-to-edit" > change the date > click UpdateTable before'n'after screenshots
1600px wide


700px wide


450px wide


This change is