Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Blacklist bad merge sets #3530

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[MergeDups] Blacklist bad merge sets #3530

merged 1 commit into from
Jan 21, 2025

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 21, 2025

Follow-up to #3523, which would have allowed the backend to keep returning the same bad set of potential duplicates.


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend goal: MergeDup labels Jan 21, 2025
@imnasnainaec imnasnainaec self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.49%. Comparing base (25cff36) to head (8377482).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/goals/Redux/GoalActions.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3530      +/-   ##
==========================================
- Coverage   74.51%   74.49%   -0.02%     
==========================================
  Files         286      286              
  Lines       11021    11023       +2     
  Branches     1344     1345       +1     
==========================================
  Hits         8212     8212              
- Misses       2421     2423       +2     
  Partials      388      388              
Flag Coverage Δ
backend 83.54% <ø> (ø)
frontend 66.48% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) January 21, 2025 16:46
@imnasnainaec imnasnainaec merged commit 117e235 into master Jan 21, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the bad-dups branch January 21, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend goal: MergeDup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants