Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup-dotnet to v4.2.0 and clear old endpoints #3527

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 16, 2025

Supersedes #3524


This change is Reviewable

hahn-kev and others added 2 commits January 16, 2025 11:38
@imnasnainaec imnasnainaec added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jan 16, 2025
@imnasnainaec imnasnainaec self-assigned this Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.55%. Comparing base (0947624) to head (f138905).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3527   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         286      286           
  Lines       11022    11022           
  Branches     1344     1344           
=======================================
  Hits         8217     8217           
  Misses       2418     2418           
  Partials      387      387           
Flag Coverage Δ
backend 83.62% <ø> (ø)
frontend 66.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, it does look like ci.dot.net was added but I suspect that would only be used if we were to try and use a nightly build in setup-dotnet so it's probably not worth adding

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) January 17, 2025 14:38
@imnasnainaec imnasnainaec disabled auto-merge January 17, 2025 14:38
@imnasnainaec imnasnainaec merged commit fcd1a2b into master Jan 17, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the update-setup-dotnet-to-fix-build branch January 17, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants