Skip to content

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 19, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend test font/language dependencies Pull requests that update a dependency file Size: S Small sized issue labels Aug 19, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 19, 2024
@codecov
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.68%. Comparing base (34b59b5) to head (ade06ed).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3313   +/-   ##
=======================================
  Coverage   74.68%   74.68%           
=======================================
  Files         280      280           
  Lines       10744    10744           
  Branches     1298     1298           
=======================================
  Hits         8024     8024           
  Misses       2354     2354           
  Partials      366      366           
Flag Coverage Δ
backend 83.89% <ø> (ø)
frontend 66.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested a review from jmgrady August 21, 2024 21:17
@jasonleenaylor
Copy link
Contributor

src/i18n/index.ts line 29 at r2 (raw file):

      detection: { order: ["queryString", "path", "navigator"] },
      supportedLngs: i18nLangs,
      // "languageOnly" will (e.g.) only load 'es' if the browser is 'es-MX'

This comment is confusing to me.
I think it trying to say that the browser will only use the language part of the tag, and not the region - but that isn't what the words are saying.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @jmgrady)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@imnasnainaec imnasnainaec merged commit b964bca into master Aug 28, 2024
@imnasnainaec imnasnainaec deleted the i18n branch August 28, 2024 14:37
@imnasnainaec imnasnainaec removed the request for review from jmgrady August 28, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file font/language frontend Size: S Small sized issue test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants