Add support for Vector2/3/4, Quaternion, Rect; expand support for RGB-only Color#89
Add support for Vector2/3/4, Quaternion, Rect; expand support for RGB-only Color#89kaycodes13 wants to merge 12 commits into
Conversation
To clarify that there's a spot to type when the field is empty.
dplochcoder
left a comment
There was a problem hiding this comment.
Mostly LG, just a couple comments left + Flib's comment about the RGB attribute
| textInputChild.FindChild("CursorRight")!.GetComponent<Animator>(), | ||
| ]; | ||
|
|
||
| GameObject underlineObj = new("Underline") { layer = (int)PhysLayers.UI }; |
There was a problem hiding this comment.
How wedded are you to this underline? I think it looked better without the underline, personally
(To be clear, I don't mean we should keep - or remove - it based solely on my opinion, but I'd like it to be scrutinized further)
| as a library to NuGet, this version will also be used as the package version. | ||
| --> | ||
| <Version>0.7.4</Version> | ||
| <Version>0.7.5</Version> |
There was a problem hiding this comment.
I think this is a case where bumping the version should be done outside the PRs - the other PR has breaking changes so the version should be 0.8 rather than 0.7.5, but it's weird to bump the version here based on the changes in the other PR. I don't think we should create a release with the other PR without this one being included - can you remove the version update from this PR and (if you want to) add it to the other PR?
Summary of Changes
Closes #78 by:
TextModelsutilities to create models forVector2,Vector3,Vector4,Quaternion, andRecttypes.TextInput.ConfigEntryFactoryandMenuProperty.Other updates folded into this:
RGBElementFactoryfor source generation of color inputs that mirrors the effect thatRGBColorValueshas for config entry element generation.Checklist