Skip to content

Minor changes#77

Merged
flibber-hk merged 6 commits into
silksong-modding:mainfrom
flibber-hk:minor-changes
May 3, 2026
Merged

Minor changes#77
flibber-hk merged 6 commits into
silksong-modding:mainfrom
flibber-hk:minor-changes

Conversation

@flibber-hk
Copy link
Copy Markdown
Member

Summary of Changes

Some minor changes I thought of while thinking about documentation:

  • Allow l10n of dynamic description elements
  • Util to create a text button to jump to a page. This doesn't work as intended for the "Mods" button (the menu is generated lazily), or the nested submenu (at least in the test, because the submenu name is not the same as the mod name), which is why I haven't replaced usages. But it does work sometimes (in cases where the menu is generated eagerly).
  • Add a virtual method to place elements onto a subpage; the intent here is that people can use the config entry factory to sometimes have scrollable screens and sometimes have paginated screens (this is the one I think is most likely to need review)

@BadMagic100 BadMagic100 self-assigned this Apr 28, 2026
Copy link
Copy Markdown
Member

@BadMagic100 BadMagic100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, did not test

@flibber-hk flibber-hk merged commit 42e8e45 into silksong-modding:main May 3, 2026
4 checks passed
@flibber-hk flibber-hk deleted the minor-changes branch May 3, 2026 09:40
This was referenced May 4, 2026
This was referenced May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants