Merged
Conversation
flibber-hk
reviewed
Apr 6, 2026
flibber-hk
reviewed
Apr 6, 2026
flibber-hk
reviewed
Apr 6, 2026
flibber-hk
reviewed
Apr 6, 2026
flibber-hk
reviewed
Apr 6, 2026
flibber-hk
reviewed
Apr 6, 2026
Member
flibber-hk
reviewed
Apr 6, 2026
flibber-hk
reviewed
Apr 6, 2026
Member
|
Approval subject to the unresolved comments (although some of them may not require action :zotesip:) |
This was referenced Apr 6, 2026
Merged
Member
|
Um, what is the intended behaviour if you do Config.Bind(new("Main.B.C", "Int7"), 7, new("ABC Integer 7"));
Config.Bind(new("Main.B.C", "Int8"), 8, new("ABC Integer 8"));What happens is that both of these get placed on the main page |
Collaborator
Author
This was not intended, fixed the algorithm so that it handles the "Main.B.C" collapse correctly. |
flibber-hk
approved these changes
Apr 6, 2026
This was referenced Apr 6, 2026
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of Changes
This is a breaking change, but only for mods that create their own custom menus (auto-gen is unaffected), and so should be released with an accompanying notification on the mod server. Like the last l10n update, the breakage is mostly source-compatible, but it does require rebuilds and it does require changing implementations of
string ModMenuName()toLocalizedText ModMenuName(). I'm not aware of any other breaking changes needed for l10n or otherwise at this time.Checklist