Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix google analytics and replace inline onclick #294

Merged
merged 7 commits into from
Nov 28, 2024
Merged

fix google analytics and replace inline onclick #294

merged 7 commits into from
Nov 28, 2024

Conversation

hobbitronics
Copy link
Contributor

No description provided.

@hobbitronics hobbitronics requested a review from a team as a code owner November 27, 2024 09:08
@hobbitronics hobbitronics requested review from briskt, forevermatt, mtompset and jason-jackson and removed request for a team November 27, 2024 09:08
@briskt
Copy link
Contributor

briskt commented Nov 27, 2024

Looks like you started the feature/fix-google-analytics branch from main but the target (feature/handle-missing-ga) is a feature branch that isn't current with main. Do you want to change the target branch of this PR, or update that branch?

@hobbitronics hobbitronics changed the base branch from feature/handle-missing-ga to main November 27, 2024 21:57
briskt
briskt approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple things to consider

modules/material/themes/material/default/selectidp-links.twig Outdated Show resolved Hide resolved
modules/material/themes/material/mfa/prompt-for-mfa-webauthn.twig Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hobbitronics hobbitronics merged commit 4763b49 into main Nov 28, 2024
3 checks passed
@hobbitronics hobbitronics deleted the feature/fix-google-analytics branch November 28, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hobbitronics @briskt @jason-jackson