feat(tunnel): Add certificate enrollment after domain join (T-5.3)#97
Merged
feat(tunnel): Add certificate enrollment after domain join (T-5.3)#97
Conversation
- Add ValidateMachineCertificate() for machine cert validation - Add GenerateCertEnrollmentScript() for AD CS enrollment via certreq - Add ParseCertificateFile() for cert info extraction - Add NeedsRenewal() for certificate renewal detection - Add WatchCertificateExpiry() for proactive renewal monitoring - Add ExtractIssuerFingerprint() for mTLS issuer verification - 32 tests covering all cert validation scenarios Validates: - SAN DNSNames (not CN!) matching hostname.domain format - Certificate expiry and minimum validity - Renewal threshold (30 days before expiry) - Case-insensitive hostname matching - Certificate chain for issuer fingerprint Closes T-5.3 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
client/internal/tunnel/certenroll.go- Certificate enrollment and validationclient/internal/tunnel/certenroll_test.go- 32 comprehensive testsKey Functions
ValidateMachineCertificate()- Validates machine cert for mTLSGenerateCertEnrollmentScript()- PowerShell AD CS enrollmentParseCertificateFile()- Extract cert infoNeedsRenewal()- Check if renewal needed (30-day threshold)WatchCertificateExpiry()- Background expiry monitorExtractIssuerFingerprint()- mTLS issuer verificationTest Plan
Checklist
Closes T-5.3
Refs #7
🤖 Generated with Claude Code