-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message on labels #633
Improve error message on labels #633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! just a quick suggestion, happy to merge after that 🙂
Co-authored-by: Simen Bekkhus <[email protected]>
👍 I didn't squash it on the branch, so squash and merge. thanks for the quick reply ❤️ |
When is this scheduled to be released ? |
I'm currently away at a festival, but I can make a release on Sunday (unless @zbjornson gets to it before me) |
had some time this morning, so published in https://github.com/siimon/prom-client/releases/tag/v15.1.3 |
This fix ensures consumers of the library get more insights into which labels are causing an error to occur.
With the new error message it is easier for a developer to debug what happened in the case where you accidentally pass in a bad argument.
If
getLabels
gets called like this:it used to throw...
now it throws this: