Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript definitions for using with Registry<OpenMetricsContentType> #571

Merged
merged 4 commits into from
May 13, 2023
Merged

Fix typescript definitions for using with Registry<OpenMetricsContentType> #571

merged 4 commits into from
May 13, 2023

Conversation

FreeRiderBysik
Copy link
Contributor

@FreeRiderBysik FreeRiderBysik commented May 13, 2023 •
edited
Loading

  1. Content types was mixed up - ContentTypes in index.d.ts are mixed up #565
  2. Methods like collectDefaultMetrics without setting generic type does not allows to work with Registry

@SimenB SimenB linked an issue May 13, 2023 that may be closed by this pull request
ContentTypes in index.d.ts are mixed up #565
Closed
SimenB
SimenB approved these changes May 13, 2023
View reviewed changes
Copy link
Collaborator

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 992d5a2 into siimon:master May 13, 2023
@lholmquist lholmquist mentioned this pull request Jun 5, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 1, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContentTypes in index.d.ts are mixed up
2 participants
@FreeRiderBysik @SimenB