Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable content encoding for pushgateway delete requests #551

Conversation

vpalmisano
Copy link
Contributor

@vpalmisano vpalmisano commented Mar 9, 2023

When using gzip Content-Encoding the DELETE requests sent to a pushgateway server fail with error code 400. With this PR we disable Content-Encoding option, if found, for DELETE requests.

@vpalmisano vpalmisano changed the title Disable content encoding for pushgateway delete requests fix: Disable content encoding for pushgateway delete requests Mar 9, 2023
@SimenB
Copy link
Collaborator

SimenB commented Mar 9, 2023

Can you add a changelog entry?

@SimenB SimenB requested a review from zbjornson March 9, 2023 17:35
Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a compliant server is supposed to ignore this and anything else related to a body, but we can definitely remove it here. 👍

Looks good % changelog entry.

@zbjornson zbjornson changed the base branch from master to next March 9, 2023 18:44
@zbjornson zbjornson changed the base branch from next to master March 9, 2023 18:44
@SimenB SimenB merged commit 0f872ff into siimon:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants