Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README): remove await of getSingleMetric #541

Merged
merged 1 commit into from
Mar 8, 2023
Merged

docs(README): remove await of getSingleMetric #541

merged 1 commit into from
Mar 8, 2023

Conversation

ric113
Copy link
Contributor

@ric113 ric113 commented Feb 17, 2023

Summary

getSingleMetric is a synchronous function, don't need to await it 😅
ref: https://github.com/siimon/prom-client/blob/master/lib/registry.js#L132

zbjornson
zbjornson approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zbjornson zbjornson merged commit 4ddf9a2 into siimon:master Mar 8, 2023
@ric113 ric113 deleted the docs/update-registry-section branch March 13, 2023 14:58
@lholmquist lholmquist mentioned this pull request Jun 5, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 1, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbjornson zbjornson zbjornson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ric113 @zbjornson