Use base units (seconds) for current time in gauge #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is the only instance where this is incorrect. Breaking change Fixes siimon#167
|
Mind updating the changelog as well? 🙂 |
|
Done! |
SimenB
approved these changes
Feb 28, 2018
|
Any chance this could get merged/released soon? |
|
Sorry, totally forgot! @SimenB do you know any other breaking changes that we would like to do before merging and relasing this? |
|
We could use this to drop node 4 support as it's EOL in one month, but nothing other than that I think. |
|
Yeah sounds like a good plan! I'll fix that! |
|
What does dropping node 4 support mean? That it's not a semver breaking change if prom-client begins using features not present in node 4? Do you anticipate any changes like that? |
|
It might (most likely) work for a long time with node 4 too. But we want to make it obvious where we dropped support for a specific version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the only instance where this is incorrect.
Breaking change
Fixes #167