Update pushgateway type def (#469)

* Update pushgateway type def

Update pushgateway typedef to reflect javascript implementation

* Update index.d.ts

Co-authored-by: Simen Bekkhus <[email protected]>

* pr feedback

* add tsd check

* Revert "add tsd check"

This reverts commit 0d591f9.

* update change log

* typo

Co-authored-by: Simen Bekkhus <[email protected]>

CHANGELOG.md

@@ -11,6 +11,12 @@ project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
+- changed: typedef for pushgateway to reflect js implementation.
+
+  Pushgateway's typedef were missing promise return type. That was
+  causing vscode to think that push/pushAdd and delete didn't promise
+  resulting in incorrect behavior.
+
 ### Added
 
 ## [14.0.0] - 2021-09-18

index.d.ts

@@ -557,32 +557,26 @@ export class Pushgateway {
 	/**
 	 * Add metric and overwrite old ones
 	 * @param params Push parameters
-	 * @param callback Callback when request is complete
 	 */
 	pushAdd(
 		params: Pushgateway.Parameters,
-		callback: (error?: Error, httpResponse?: any, body?: any) => void,
-	): void;
+	): Promise<{ resp?: unknown, body?: unknown }>;
 
 	/**
 	 * Overwrite all metric (using PUT to Pushgateway)
 	 * @param params Push parameters
-	 * @param callback Callback when request is complete
 	 */
 	push(
 		params: Pushgateway.Parameters,
-		callback: (error?: Error, httpResponse?: any, body?: any) => void,
-	): void;
+	): Promise<{ resp?: unknown, body?: unknown }>;
 
 	/**
 	 * Delete all metrics for jobName
 	 * @param params Push parameters
-	 * @param callback Callback when request is complete
 	 */
 	delete(
 		params: Pushgateway.Parameters,
-		callback: (error?: Error, httpResponse?: any, body?: any) => void,
-	): void;
+	): Promise<{ resp?: unknown, body?: unknown }>;
 }
 
 export namespace Pushgateway {