Re-implement missing jruby functionality atop java.security #192
+154
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/re-implement-missing-jruby-functionality-atop-java.security
branch
from
3be06b6 to
882a525
Compare
segiddins
force-pushed
the
segiddins/re-implement-missing-jruby-functionality-atop-java.security
branch
from
882a525 to
51f9811
Compare
Signed-off-by: Samuel Giddins <[email protected]>
segiddins
force-pushed
the
segiddins/re-implement-missing-jruby-functionality-atop-java.security
branch
from
51f9811 to
b97e5ad
Compare
segiddins
commented
Feb 14, 2025
| @@ -309,11 +381,15 @@ def parse_value(value) | |||
| @general_names = value.map do |general_name| | |||
| tag = general_name.tag | |||
|
|
|||
| value = general_name.value | |||
| value = value.first if value.is_a?(Array) && value.size == 1 | |||
There was a problem hiding this comment.
i think this is a jruby discrepancy here -- file issue for it
There was a problem hiding this comment.
|
Cc @headius, I think this works around most of the incompatibilities / missing features needed from jruby-openssl |
woodruffw
approved these changes
Feb 18, 2025
|
This is a very cool set of changes! We are fully willing to include pure-Ruby fixes in jruby-openssl if it makes sense for us to do so, and moving that library as much as possible toward 100% java.security is a key goal of mine. @segiddins We would love to see PRs for any appropriate changes you've made to work around jruby-openssl. @kares I think it's worth exploring these and other changes to try to improve functionality and slowly chip away at how much Bouncy Castle we need. |
…nality-atop-java.security
segiddins
deleted the
segiddins/re-implement-missing-jruby-functionality-atop-java.security
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samuel Giddins [email protected]