Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow ManualTrustRoot to hold multiple Rekor keys #349

Conversation

flavio
Copy link
Member

@flavio flavio commented Apr 9, 2024

The sigstore::trust::sigstore::SigstoreTrustRoot can hold multiple Rekor keys.

The possibility to have multiple keys is also reflected by the sigstore::trust::TrustRoot.rekor_keys trait.

This commit allows the ManualTrustRoot object to hold multiple Rekor keys.

The `sigstore::trust::sigstore::SigstoreTrustRoot` can hold multiple
Rekor keys.

The possibility to have multiple keys is also reflected by the
[`sigstore::trust::TrustRoot.rekor_keys`](https://docs.rs/sigstore/0.9.0/sigstore/trust/trait.TrustRoot.html#tymethod.rekor_keys)
trait.

This commit allows the `ManualTrustRoot` object to hold multiple Rekor
keys.

Signed-off-by: Flavio Castelli <[email protected]>
Copy link
Collaborator

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavio
Copy link
Member Author

flavio commented Apr 12, 2024

Closing, this is part of #311

@flavio flavio closed this Apr 12, 2024
@flavio flavio deleted the manual-trust-root-hold-multiple-rekor-keys branch April 12, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants