Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: investigate removal of pikcy-rs #308

Closed
flavio opened this issue Nov 14, 2023 · 0 comments · Fixed by #313
Closed

Refactor: investigate removal of pikcy-rs #308

flavio opened this issue Nov 14, 2023 · 0 comments · Fixed by #313
Assignees
@flavio
Labels
enhancement New feature or request

Comments

@flavio
Copy link
Member

flavio commented Nov 14, 2023

Description

Investigate if the pikcy-rs dependency could be replaced by rustls-webpki. The latter library has been recently introduced as one of our dependencies.

In the beginning we didn't use the rustls-webpki library because it didn't exist. rustls-webpki is a fork of webpki, which didn't have the features we needed and, most important of all, was struggling with maintenance. The fork seems to have addressed these issues.
@flavio flavio added the enhancement New feature or request label Nov 14, 2023
@flavio flavio self-assigned this Dec 1, 2023
flavio added a commit to flavio/sigstore-rs that referenced this issue Dec 1, 2023
@flavio
deps: remove picky-rs dependency
6a2d960 
This is no longer needed since we've moved to rustls-webpki

This closese sigstore#308

Signed-off-by: Flavio Castelli <[email protected]>
@flavio flavio mentioned this issue Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flavio flavio

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken tests, update deps flavio/sigstore-rs
1 participant
@flavio