don't parse error messages as json

[bobcallaway]

Summary

I don't think we need to pass a parsed JSON object up to the caller in the context of RekorClientError

@woodruffw thoughts?

[woodruffw]

Agreed!

Does the Rekor REST API specify anywhere that it may return JSON vs. plain text on error codes? I don't think it's a significant issue, but if we ever elaborate on this exception type it'd be nice to know what we can rely on/assume.

[woodruffw]

Nonblocking, but mind adding a small CHANGELOG entry as well? Something under the "Fixed" category to the effect of "Fixed an assumption about Rekor error responses that was causing crashes"

If not, I can add it later.

[bobcallaway]

Nonblocking, but mind adding a small CHANGELOG entry as well? Something under the "Fixed" category to the effect of "Fixed an assumption about Rekor error responses that was causing crashes"

If not, I can add it later.

I'll add it, no problem.

[bobcallaway]

Agreed!

Does the Rekor REST API specify anywhere that it may return JSON vs. plain text on error codes? I don't think it's a significant issue, but if we ever elaborate on this exception type it'd be nice to know what we can rely on/assume.

not really? The Content-Type on the response is text/html; charset=UTF-8 so while I don't think we're out of HTTP spec, I'm not sure where we'd declare it (perhaps in the openapi.yaml file?)