Skip to content

_cli: emit only sigstore bundle by default #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 23, 2023

Conversation

tnytown
Copy link
Contributor

@tnytown tnytown commented Apr 14, 2023

  • Adjust CLI to emit only {input}.sigstore by default. Signature and certificate outputs are still supported, but users will have to pass the respective flags to generate them.
  • Remove --no-bundle, as its functionality now overlaps with --no-default-files.
  • Fail on multiple input case when --bundle is specified.
  • Adjust CLI help to reflect all of the above.

Would we also want to change the stability of the --bundle option within the release?

Resolves #592.

@tnytown tnytown requested review from di, woodruffw and tetsuo-cpp April 14, 2023 19:07
@tnytown tnytown added enhancement New feature or request component:cli CLI components labels Apr 14, 2023
@tnytown tnytown self-assigned this Apr 14, 2023
tnytown added 2 commits April 14, 2023 14:11
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
@tnytown tnytown marked this pull request as ready for review April 23, 2023 14:59
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw merged commit e1ed0bb into sigstore:main Apr 23, 2023
@woodruffw woodruffw deleted the ap/issue/592 branch April 23, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cli CLI components enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: stop emitting .sig and .crt signing outputs
2 participants