-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oauth: Use the new and improved Sigstore redirect page #356
Conversation
0344367
to
3bf78fc
Compare
</html> | ||
""" | ||
""" # noqa: E501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just decided to silence Ruff here as I don't think it helps readability to insert line breaks for this type of string.
Thanks @julienv3, this looks great. |
This is (mostly?) code copied from sigstore/sigstore right? Should include some authorship info in the commit as well -- it's good for tracking copyrights but also good for the authors internet fame and fortune (not everyone cares about that but it's still nice). Adding a "Co-authored-by:" to the commit message would trigger at least github noticing the contribution, maybe that's good enough? |
My mistake, I completely forgot about that. I'll add the "co-authored-by" to attribute the commit to @julienv3 and add a comment in the code to explain where it's from and who wrote it. How does that sound? |
98beeb3
to
98e7e89
Compare
Signed-off-by: Alex Cameron <[email protected]> Co-authored-by: julienv3 <[email protected]>
98e7e89
to
02bb65a
Compare
LGTM! Per #361 we might to eventually move this to a stand-alone template or file, since that might help with automatic syncing against |
Closes #354