expand examples documentation#412
Merged
steiza merged 2 commits intosigstore:mainfrom Feb 20, 2025
Merged
Conversation
dmitris
force-pushed
the
examples-build-usage
branch
from
5c02bd2 to
298e8fc
Compare
dmitris
force-pushed
the
examples-build-usage
branch
from
298e8fc to
f9d4eed
Compare
steiza
reviewed
Feb 19, 2025
Member
steiza
left a comment
steiza
left a comment
There was a problem hiding this comment.
Generally looks good to me - a few minor comments / suggestions.
Signed-off-by: Dmitry Savintsev <dsavints@gmail.com>
dmitris
force-pushed
the
examples-build-usage
branch
from
f9d4eed to
e1cf27b
Compare
Contributor
Author
|
thanks @steiza - addressed your feedback |
Signed-off-by: Dmitry Savintsev <dsavints@gmail.com>
dmitris
force-pushed
the
examples-build-usage
branch
from
e1cf27b to
53ba2c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR expands the documentation for the examples. The order of
go buildcommands in the Makefile for thebuild-examplestarget is changes to correspond to the alphabetical sorted order.Release Note
NONE
Documentation
examples/README.mdis updated and expanded, no other documentation changes are necessary.